[
https://issues.apache.org/jira/browse/TIKA-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Nistor updated TIKA-1137:
--------------------------------
Attachment: patch.diff
> Wasted work in WontBeSerializedError.writeObject()
> --------------------------------------------------
>
> Key: TIKA-1137
> URL: https://issues.apache.org/jira/browse/TIKA-1137
> Project: Tika
> Issue Type: Bug
> Affects Versions: 1.3
> Environment: any
> Reporter: Adrian Nistor
> Labels: patch, perfomance
> Attachments: patch.diff
>
>
> The problem appears in version 1.3 and in revision 1494353. I
> attached a one-line patch that fixes it.
> In method "WontBeSerializedError.writeObject", the loop over
> "e.getStackTrace()" should break immediately after "found" is set to
> "true". All the iterations after "found" is set to "true" do not
> perform any useful work, at best they just set "found" again to
> "true".
> Method "embedInTempFile" in class "ExternalEmbedderTest" has a similar
> loop (over "embeddedMetadata.getValues(metadataName)"), and this loop
> breaks immediately after "foundExpectedValue" is set to "true", just
> like in the proposed patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
