On Tue, Aug 7, 2018 at 11:45 AM, Laslo Hunhold <d...@frign.de> wrote:
> On Mon, 6 Aug 2018 16:42:19 +0300
> Alexander Krotov <ilab...@gmail.com> wrote:
>
> Dear Alexander,
>
>> With this patch the bar can at least be hidden before opening web
>> pages that cause Xft errors.
>
> I agree with the patch, but not because of the Xft bug. We should just
> not execute code that is unnecessary.
>
> Maybe we can layer this check out though and do a
>
> if (m->showbar) {
> drawbar(...)
> }
>
> What do you guys think?
I don't mind either way as long as we don't execute code that we don't need.
Only calling drawbar() when we actually want to show the bar would
make the intent clearer.
Cheers,
Silvan
