On Tue, Apr 3, 2018, at 21:12, harry666t wrote:
> My take - if you don't mind Go...
> https://github.com/rollcat/gdoh
> No forking, no dependencies outside of stdlib, async
> queries/responses, allows using multiple providers, 78 loc.
There is a small bug on line 34: if the statuscode isn't 200 then the
response body is never closed. You should move the "defer
r.Body.Close()" to above the "if r.StatusCode != 200 {" check.
Probably not a huge deal since this is a command line client, but in
long-running servers this will cause file descriptor leaks.
