Hi Ben, Actually the patch I provided would remove the shadow from dmenu because it would be flagged as "dock". However, I also realized that it might be something useful for dmenu. For dwm I think it's totally useless and it should definitely be flagged as dock.
Cheers. Jan Christoph On Sun 24-07-2016 20:41 -0700, Ben Woolley wrote: > Don't be discouraged by the other replies. I have been caught off > guard by a dmenu of my own use being a bit too subtle for me to > notice, and a shadow would have made it more clear that a new object > needs attention. Not sure why anyone would complain about a UI > advancement that is both trivial and backed by years of research. > > > On Jul 24, 2016, at 12:56 PM, Jan Christoph Ebersbach <j...@e-jc.de> > > wrote: > > > > Hi, > > > > Here are the patches to set _NET_WM_WINDOW_TYPE_DOCK for dwm's bar > > and dmenu. Would someone with commit rights apply them to master? > > > > Thank you. > > > > Jan Christoph > > > > > On Wed 20-07-2016 07:05 +0200, Jan Christoph Ebersbach wrote: > > > > > > Great, thanks for the feeback. I'll provide a patch this week. > > > > > > Jan Christoph > > > > > > > On Tue 19-07-2016 20:47 +0200, v4hn wrote: > > > > > > > > Where's the patch? > > > > > > > > On Tue, Jul 19, 2016 at 07:43:26PM +0200, Jan Christoph > > > > Ebersbach wrote: > > > >> Hi, > > > >> > > > >> I just stumbled upon the compositor compton and came across > > > >> this wiki page that describes that shadows don't work properly > > > >> in combination with dwm and dmenu: > > > >> https://wiki.archlinux.org/index.php/Compton#dwm_.26_dmenu The > > > >> reason for this is that _NET_WM_WINDOW_TYPE and > > > >> _NET_WM_WINDOW_TYPE_DESKTOP aren't set for the bar/menu that is > > > >> drawn. > > > >> > > > >> The closest I could get in my research was > > > >> http://comments.gmane.org/gmane.comp.misc.suckless/7688. dwm > > > >> implements _NET_WM_WINDOW_TYPE for client windows. > > > >> > > > >> Is there a specific reason for not implementing > > > >> _NET_WM_WINDOW_TYPE for dwm and dmenu other than that nobody > > > >> did it so far? I think it's worth the issue because a > > > >> compositor greatly improves window tearing and it would make > > > >> the tools more compatible to the expected behavior. > > > >> > > > >> Btw, here is another issue related to compositors that might be > > > >> worth considering again: > > > >> http://lists.suckless.org/dev/1505/26735.html > > > >> > > > >> Jan Christoph > > > > -- Jan Christoph Ebersbach I didn’t want some petty, inferior brand > > of righteousness that comes from keeping a list of rules when I > > could get the robust kind that comes from trusting Christ - God’s > > righteousness. Phil 3:9 <0001-Mark-barwin-type-as-dock_dwm.patch> > > <0001-Mark-window-type-as-dock_dmenu.patch> > -- Jan Christoph Ebersbach I didn’t want some petty, inferior brand of righteousness that comes from keeping a list of rules when I could get the robust kind that comes from trusting Christ - God’s righteousness. Phil 3:9
signature.asc
Description: PGP signature
