On Wed, 27 Jan 2016 20:18:17 +0100
Mattias Andrée <[email protected]> wrote:

Hey Mattias,

thanks for your patch. I haven't looked at it in-depth, but would like
to advise you instead of using this macro-beast:

> +#define printf(...)  do  {if (printf(__VA_ARGS__) < 0) perror("printf"), 
> exit(EXIT_FAILURE); } while(0)

to rather call fshut on stdout at the end of the program. This will
ensure that in case a write fails, it is well-reported.
It's already bad enough we see these macro-wonders in glibc.

Cheers

FRIGN

-- 
FRIGN <[email protected]>

Reply via email to