‎I also forgot to bump the size of cmd[] for this one, too. 

Ben
  Original Message  
From: Ben Woolley
Sent: Wednesday, January 7, 2015 3:18 PM
To: dev mail list
Subject: disk cache patch

Hi all,

It turns out that enabling libsoup's disk cache is fairly straightforward.

I left it enabled by default in the patch, but I am not proposing that in any 
way. I am pretty sure this will apply fairly cleanly with other patches, except 
maybe the change of the size of the togglestat struct.

There is probably a concurrency issue with this, where multiple surf instances 
open the same cache. Note that I load on startup, and flush after each page 
load. At least I haven't run into any corruption issues with it, so maybe the 
worst that comes of that issue is fewer cache hits. Compared to no cache at 
all, it is an improvement. 

I used the command line options "d" and "D". 

Beware that a disk cache may hold cache-based trackers for a longer duration 
than the memory-only cache that is the default. I recommend disabling the cache 
in any private sessions. 

Thanks,

Ben


Reply via email to