Roberto E. Vargas Caballero wrote: > I am used to fallthrough (maybe because I didn't put mark ever), > but maybe is not the same for all the programmers :?. > This patch is more about style that real benefit of the changes. I > usually reuse all the possible paths of a switch to avoid code duplication.
Heyho Roberto, usually the compiler should fix this code duplication, at least with -Os set. So, before the patch, the code is easier to read and the compiler takes care of code deduplication. After the patch you save some compiler optimization time versus a little longer parsing time due to a few more lines of code which are also less intuitive. I think we're better off without this one. --Markus
