Re: [dev] [st] Colors slightly different hue than in xterm

[Eric Pruitt]

On Mon, Dec 02, 2013 at 01:40:12AM +0100, Markus Teich wrote:
> Heyho,
> 
> Seems to be related to the colors of bold/bright text.
> 
> --Markus

Brilliant! I feel silly for not noticing it only affected the bold
colors. The fix was simple, and I've attached a patch in the event other
people prefer the xterm behavior.

Thanks,
Eric

diff --git a/st.c b/st.c
index 91eb2cc..d952bfd 100644
--- a/st.c
+++ b/st.c
@@ -3093,18 +3093,10 @@ xdraws(char *s, Glyph base, int x, int y, int charlen, int bytelen) {
 		if(BETWEEN(base.fg, 0, 7)) {
 			/* basic system colors */
 			fg = &dc.col[base.fg + 8];
-		} else if(BETWEEN(base.fg, 16, 195)) {
-			/* 256 colors */
-			fg = &dc.col[base.fg + 36];
-		} else if(BETWEEN(base.fg, 232, 251)) {
-			/* greyscale */
-			fg = &dc.col[base.fg + 4];
 		}
 		/*
 		 * Those ranges will not be brightened:
 		 *    8 - 15 – bright system colors
-		 *    196 - 231 – highest 256 color cube
-		 *    252 - 255 – brightest colors in greyscale
 		 */
 		font = &dc.bfont;
 		frcflags = FRC_BOLD;