Roberto E. Vargas Caballero dixit: >On Wed, Nov 13, 2013 at 01:03:47PM +0000, Thorsten Glaser wrote: >> Roberto E. Vargas Caballero dixit: >> >> >long, because long is at least 32 bits for sure, but int can be only 16 >> >> On POSIX, int is a minimum 32 bit data type. > >I prefer follow the ISO rules about data sizes.
That is stupid because this is a POSIX application and will not work without POSIX stuff anyway. >If you want 32 bits use uint32_t, in other case I will not apply the patch. The idea here is that “int” is faster than either “long” or “int32_t” – the former is for specific cases where int is not enough, and the latter will be forcibly 32-bit even if int is 64 bit on some machines where this is faster. You could use “int_fast32_t” if you’re so pedantic. But just using “int” here is probably the right thing to do. bye, //mirabilos -- „Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund, mksh auf jedem System zu installieren.“ -- XTaran auf der OpenRheinRuhr, ganz begeistert (EN: “[…]uhr.gz is a reason to install mksh on every system.”)