On Mon, Jul 15, 2013 at 02:00:35AM +0200, Jens Nyberg wrote: > Hi, > > I've included a patch that makes minor changes to md5 and sha1. Both > hashing functions are pretty similar but the code differed in a few places > so I cleaned them both up a bit. > > Also I made some minor changes like moving the rol function to below the > definitions and also instead of *= 8 I did a <<= 3 which is functionally > equivalent but should save a tiny bit of speed (unless the compiler is > smart enough to catch that and replaces it automatically).
I'd break this patch into multiple patches. The change from *= 8 to <<= 3 doesn't make sense. Maybe it did in the 80s but not anymore.
