On 06/05/2013, Johannes Hofmann <johannes.hofm...@gmx.de> wrote:
> Hi,
>
> there is a small glitch in the error handling of the select() call
> in st.c. See patch below.
>
> Regards,
> Johannes
>
> diff --git a/st.c b/st.c
> index 5251e70..689de26 100644
> --- a/st.c
> +++ b/st.c
> @@ -3481,7 +3481,7 @@ run(void) {
> FD_SET(cmdfd, &rfd);
> FD_SET(xfd, &rfd);
>
> - switch(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv) < 0) {
> + switch(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv)) {
> case -1:
> if(errno == EINTR)
> continue;
>
Why are we even using switch here?
>From 8cf77d2d081702c7e0db2bb8724732ca0fa85410 Mon Sep 17 00:00:00 2001
From: Strake <strake...@gmail.com>
Date: Mon, 6 May 2013 06:29:21 -0500
Subject: [PATCH] (if rather than switch) select ...
---
st.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/st.c b/st.c
index bd157af..1191969 100644
--- a/st.c
+++ b/st.c
@@ -3347,12 +3347,12 @@ run(void) {
FD_SET(cmdfd, &rfd);
FD_SET(xfd, &rfd);
- switch(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv) < 0) {
- case -1:
+ if(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv) < 0) {
if(errno == EINTR)
continue;
die("select failed: %s\n", SERRNO);
- default:
+ }
+ else {
if(FD_ISSET(cmdfd, &rfd)) {
ttyread();
if(blinktimeout) {
@@ -3364,7 +3364,6 @@ run(void) {
if(FD_ISSET(xfd, &rfd))
xev = actionfps;
- break;
}
gettimeofday(&now, NULL);
drawtimeout.tv_sec = 0;
--
1.7.11.1
