Re: [dev] [PATCH v2] dmenu_run: Don't leave a shell running

[Chris Down]

On 2013-04-16 14:47, Ross Lagerwall wrote:
> The previous logic leaves a shell running for the duration that the
> launched application runs.
> This changes it so that the only application that is left running is
> the launched application.
> ---
>  dmenu_run | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dmenu_run b/dmenu_run
> index 834ede5..d05e131 100755
> --- a/dmenu_run
> +++ b/dmenu_run
> @@ -1,2 +1,2 @@
>  #!/bin/sh
> -dmenu_path | dmenu "$@" | ${SHELL:-"/bin/sh"} &
> +eval "exec "$(dmenu_path | dmenu "$@")
> --
> 1.8.2.1

Your usage of eval is not needed and can result in unintended consequences. Drop
the quotes around the command substitution if that's what you really want.

Chris

pgpcnn0SaIFGq.pgp
Description: PGP signature