On Tue, Feb 05, 2013 at 02:18:18PM +0100, markus schnalke wrote:
> [2013-02-05 13:16] v4hn <m...@v4hn.de>
> > SNOTES_EDITOR=${VISUAL:-${EDITOR:-vi}}
> > SNOTES_EDITOR="xterm -e $SNOTES_EDITOR"
> > cat > $HOME/.snotes/config <<EOF
> > SNOTES_EDITOR="$SNOTES_EDITOR"
> > [...]
> >
> > You may choose.
>
> The first two of my suggestions are very much ideoms, whereas
> both of your suggestions would produce unexpected behavior for me.
I honestly don't see any unexpected behaviour here.
This makes the config simply more readable than your solution
and as people will most likely not want to use xterm or a command line
editor they will in most cases edit the config anyway.
> Let my suggest a solution: [...]
>
> SNOTES_EDITOR="xterm -e ${VISUAL:-${EDITOR:-vi}}"
Fine with me, I just pushed this. Thank you for your criticism.
v4hn
pgpvZ7e1IPYN7.pgp
Description: PGP signature
