On 11 December 2012 18:33, Antonio Quartulli <or...@autistici.org> wrote: > On Tue, Dec 11, 2012 at 06:25:04PM +0100, Christoph Lohmann wrote: >> On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner <m...@brain-dump.org> >> wrote: >> > On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote: >> > > > > Please send patches as attached files. >> > > > >> > > > Since we are using now git, it is easier and logic send the patches in >> > > > this >> > > > way, so the code of the patch can be included and modified in replies. >> > > > You >> > > > only have to use git am if you want to incorpore then to the main >> > > > repository >> > > > ,and it will keep the correct author and commiter, that I can see this >> > > > information is lost now (I think it is not the correct way put a >> > > > 'thanks' in >> > > > the commit message). >> > > >> > > I won’t accept such patches. Please send attached files. I won’t imple‐ >> > > ment the outdated mbox or Maildir format for this. >> > >> > That is retarded. Inline patches which facilitate commenting are the >> > prefered patch format. Get familiar with your git tools. >> >> No. >> > > Ah, I just got onto this thread..maybe this is why my patch: "[PATCHv2] dwm: > replace deprecated XKeycodeToKeysym" had not been reviewed/commented? :)
We had a similar patch already which I first applied and then reverted to the old XKeycodeToKeysym() call, as it would require cumbersome fallback behavior to XKeycoceToKeysym() on older X servers. Cheers, Anselm
