Hello.

On Sun, 07 Oct 2012 11:55:50 +0200 "Roberto E. Vargas Caballero" 
<k...@shike2.com> wrote:
> > I applied the patch for it to have a reason to modularize the tsetchar()
> > function. I think this will be needed for  another  feature  I  have  in
> > mind.  Then the test loop will be removed.
> 
> Uhmmm, you could say me this and it was very easy for me split the patch and
> keep only that part. Next time I will try split this kind of patches.

You  didn’t  do anything wrong. Patches should normally create full fea‐
tures instead of just frameworks. So your patch is right.


Sincerely,

Christoph Lohmann


Reply via email to