On Mon, 25 Apr 2011 10:56:15 +0200, Troels Henriksen <at...@sigkill.dk> wrote: > Aurélien Aptel <aurelien.ap...@gmail.com> writes: > >> On Sun, Apr 24, 2011 at 8:10 PM, David Tweed <david.tw...@gmail.com> >> wrote: >>> to convert DefaultBG and DefaultFG from #define's into full C >>> variables with defaults and add option partsing code to set them >>> according to -fg and -bg. (The simplest thing would be to make the >>> argument be an array index rather than parsing a colour spec.) Before >>> I start working on a patch, does that sound like the appropriate way >>> to do this or is there a different way of handling colour that's being >>> envisaged? >> >> A X11 parsable color is better (#rrggbb, "light red", etc). > > This is true, because then XAllocNamedColor will handle everything for > you. > > It is also worth considering whether to handle this via X Resources (the > ~/.Xdefaults file) instead of command line options - since a terminal is > not normally something you are going to start by invoking directly, but > rather through a shortcut in your window manager.
The only reason I see for having the bg-color changed at runtime is, that I have special cases in which I want a red or green or so bg terminal. If I just want to set the default bg, it should imho be done in config.h. -jan
