On 22 November 2010 12:01, Anselm R Garbe <garb...@gmail.com> wrote: > I prefer to keep cleanup() even if it slows down the performance > (which I doubt will be noticeable) just for the sake of keeping the > symmetry that the code that allocates resources also deallocates them. > This might sound a bit pedantic and useless in case of dmenu, but I > prefer to be consistent here.
I think that pedantic and useless code for the sake of consistency is more at home in GNU software than in Suckless. If code is provably a waste of time and space it should have no place in dmenu. If memory was allocated during use I would agree with you, as a leak would be possible. But it isn't. Besides, asymmetry is beautiful. cls
