Hi,

I noticed that in surf sometimes the downloads don't even start, so
reading the surf code I found the following two lines at
loadstatuschange():

423     if(c->download)
424         stop(c, NULL);

Why are they there? They don't make any sense to me, and removing them
the downloads work fine.

I attach a patch fixing this issue and a warning in compilation.

Kind regards,
-- nibble
diff -r d9f551056ece surf.c
--- a/surf.c	Mon Mar 29 17:49:34 2010 +0200
+++ b/surf.c	Wed Apr 07 11:27:02 2010 +0200
@@ -420,8 +420,6 @@
 
 void
 loadstatuschange(WebKitWebView *view, GParamSpec *pspec, Client *c) {
-	if(c->download)
-		stop(c, NULL);
 	switch(webkit_web_view_get_load_status (c->view)) {
 	case WEBKIT_LOAD_COMMITTED:
 		setatom(c, uriprop, geturi(c));
@@ -430,6 +428,7 @@
 		c->progress = 0;
 		update(c);
 		break;
+	case WEBKIT_LOAD_FAILED:
 	case WEBKIT_LOAD_PROVISIONAL:
 	case WEBKIT_LOAD_FIRST_VISUALLY_NON_EMPTY_LAYOUT:
 		break;

Reply via email to