On Wed, 29 Jul 2026 at 18:34, Jun Omae <[email protected]> wrote: > On Wed, Jul 29, 2026 at 8:09 PM Ivan Zhakov <[email protected]> wrote: > > > > On Thu, 23 Jul 2026 at 18:04, Jun Omae <[email protected]> wrote: > > > > [..] > >> > >> > After the changes for CheckCompilerFlag are commented temporarily, the > >> > following error is occurred. > >> > The Intl::Intl is added in 3.20. > >> > See https://cmake.org/cmake/help/latest/module/FindIntl.html > >> > > >> > [[[ > >> > -- Found Intl: /usr/include > >> > CMake Error at CMakeLists.txt:453 (add_library): > >> > add_library cannot create ALIAS target "external-intl" because > target > >> > "Intl::Intl" is imported but not globally visible. > >> > ]]] > >> > > >> > >> Fixed in r1936526. > >> > > It looks the workaround from r1936526 is no longer needed since we > bumped CMake minimum required version to 3.20 (r1936635) > > > > I have tested build with CMake 3.20 and r1936526 reverted: the build > works fine. > > > > See cmake 3.18 release notes, > https://cmake.org/cmake/help/latest/release/3.18.html#commands > > > The add_library() and add_executable() commands learned to create Alias > Targets referencing non-GLOBAL Imported Targets. > > The workaround is no longer needed for cmake 3.18 or later. > >
> > So I suggested to revert r1936526. > > > > WDYT? > > > > I have no objection. > > Done in r1936758 <https://svn.apache.org/r1936758>. Thanks! -- Ivan Zhakov
