Done in r1935598 <https://svn.apache.org/r1935598>.
On Tue, 23 Jun 2026 at 19:58, Jun Omae <[email protected]> wrote: > Confirmed the compiling message catalogs works without the adding to PATH. > Could you please remove the unnecessary step? > > > https://github.com/jun66j5/subversion/actions/runs/28039419291/job/83001693494#step:14:201 > > https://github.com/jun66j5/subversion/commit/3b1d01f325a8aafb7b9ee9ad2004b61a03a7a6bc > > > Jun Omae <[email protected]> (大前 潤) > > On Wed, Jun 24, 2026 at 2:21 Timofei Zhakov <[email protected]> wrote: > >> On Tue, Jun 23, 2026 at 6:35 PM Ivan Zhakov <[email protected]> wrote: >> >>> On Tue, 23 Jun 2026 at 17:53, Ivan Zhakov <[email protected]> wrote: >>> >>>> On Tue, 23 Jun 2026 at 17:35, Jun Omae <[email protected]> wrote: >>>> >>>>> >>>>> Jun Omae <[email protected]> (大前 潤) >>>>> >>>>> On Wed, Jun 24, 2026 at 0:20 Ivan Zhakov <[email protected]> wrote: >>>>> >>>>>> On Fri, 15 May 2026 at 15:38, <[email protected]> wrote: >>>>>> >>>>>>> Author: jun66j5 >>>>>>> Date: Fri May 15 13:38:15 2026 >>>>>>> New Revision: 1934221 >>>>>>> >>>>>>> Log: >>>>>>> gha: Enable all features on CI build with cmake. >>>>>>> >>>>>>> * .github/workflows/cmake.yml >>>>>>> (Install dependencies (Windows, vcpkg)): >>>>>>> Add gettext[tools] and pdcurses. >>>>>>> (Install dependencies (Linux, apt-get)): >>>>>>> Add apache-dev, gettext, libncurses-dev. >>>>>>> (Install dependencies (Mac OS, homebrew)): >>>>>>> Add gettext and ncurses. >>>>>>> (Configure CMake): >>>>>>> Enable all features. >>>>>>> >>>>>>> [...] >>>>>> >>>>>> >>>>>>> >>>>>>> @@ -180,10 +184,16 @@ jobs: >>>>>>> >>>>>>> - name: Configure CMake >>>>>>> run: > >>>>>>> + if ($env:RUNNER_OS -eq 'Windows') { >>>>>>> + $env:PATH += ";${env:VCPKG_ROOT}\installed\${{ >>>>>>> matrix.vcpkg_triplet }}\bin"; >>>>>>> + }; >>>>>>> >>>>>> A small nitpick: it looks like this part was not mentioned in the log >>>>>> message. >>>>>> >>>>>> Could you clarify the purpose of this change? I think that >>>>>> cmake/vcpkg should work without needing a workaround like this. And if >>>>>> it's >>>>>> not working, we should probably address the root cause in our CMake >>>>>> implementation. >>>>>> >>>>> >>>>> msgfmt.exe (gettext[tools]) is needed to compile message catalogs. >>>>> >>>> >>>> I think CMake should find full path to msgfmt.exe via vcpkg. >>>> >>>> I see that CMake uses ${GETTEXT_MSGFMT_EXECUTABLE} and according to >>> documentation [1]: >>> [[[ >>> The full path to the msgfmt tool for compiling message catalog to a >>> binary format. >>> ]]] >>> >>> So I think it should work without changing the PATH. >>> >>> Could you please check to see if this is the case? Or to confirm that in >>> reality it doesn't work without changing the PATH environment variable. >>> >>> [1]: >>> https://cmake.org/cmake/help/latest/module/FindGettext.html#cache-variables >>> >> >> Hey, >> >> I'm pretty sure the module should be able to find it without any >> modification because it should check ${prefix}/bin where prefix could be >> any of CMAKE_PREFIX_PATH, CMAKE_INSTALL_PREFIX, or whatever magic the vcpkg >> toolchain uses for that. Indeed I was compiling in the same configuration >> in a local environment (with vcpkg) without changing any additional >> options. >> >> Did you test it without changing PATH? >> >> -- >> Timofei Zhakov >> > -- Ivan Zhakov
