Den sön 17 maj 2026 kl 22:51 skrev Branko Čibej <[email protected]>: > > On 17. 5. 26 22:43, Daniel Sahlberg wrote: > > Den sön 10 maj 2026 kl 14:44 skrev Branko Čibej <[email protected]>: > > On 9. 5. 26 08:41, Branko Čibej wrote: > > Hi all, > > This is just to let you know that I'm working on updating JavaHL. Not adding > everything that's missing, > but updating the use of deprecated APIs and adding things like WC-version and > store-pristines options. > > I'll try to get this ready for the next 1.15.0 release candidate. > > > Done as much as I can be bothered to. Please review branches/javahl-1.15. I'd > like to merge that to trunk soon and propose for backport to 1.15.x for the > next release candidate. > > Tested on ARM64 with JDK 1.8, 11 and 25. > > -- Brane > > > Hi, > > First: Tested on x64 (Ubuntu 26.04) with JDK 11, 17, 21 and 25. All tests > pass. > > I've been doing my best to review, but I must admit I'm far from a > Java developer (I did something in highschool, but that was Java > 1.2...) > > The only thing that stood out was the new constructor in Info.java. > Why is it private? > > > Because no-one has any business creating new Info objects. It's called from > the native code which happily ignores access control. > > We can still make it public if anyone objects, but we can't make it private > after it has been published.
Right, so I understand it was a not correct that it was public from the very start and now we take the opportunity to make it private. In that case I'm happy. Thanks, Daniel
