Re: svn commit: r1933812 - subversion/trunk

[Timofei Zhakov]

On Wed, May 6, 2026 at 10:17 AM Jun Omae <jun6...@gmail.com> wrote:
>
> On 2026/05/06 15:30, Timofei Zhakov wrote:
> >> Ad hoc patch:
> >>
> >> [[[
> >> diff --git a/CMakeLists.txt b/CMakeLists.txt
> >> index c161b7030..0ba7d260e 100644
> >> --- a/CMakeLists.txt
> >> +++ b/CMakeLists.txt
> >> @@ -231,6 +231,14 @@ endif()
> >>
> >>  if (SVN_ENABLE_SWIG_PERL OR SVN_ENABLE_SWIG_PYTHON OR 
> >> SVN_ENABLE_SWIG_RUBY)
> >>    include(UseSWIG)
> >> +  set(SWIG_INCLUDE_DIRECTORIES
> >> +    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/bindings/swig/include
> >> +    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/bindings/swig
> >> +    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/include
> >> +
> >> +    ${CMAKE_CURRENT_BINARY_DIR}/subversion/bindings/swig/proxy
> >> +    ${CMAKE_CURRENT_BINARY_DIR}
> >> +  )
> >>  endif()
> >>
> >>  # Setup modules path
> >> @@ -559,15 +567,6 @@ if(SVN_ENABLE_SWIG_PERL OR SVN_ENABLE_SWIG_PYTHON OR 
> >> SVN_ENABLE_SWIG_RUBY)
> >>
> >>    file(MAKE_DIRECTORY 
> >> "${CMAKE_CURRENT_BINARY_DIR}/subversion/bindings/swig/proxy")
> >>
> >> -  set(SWIG_INCLUDE_DIRECTORIES
> >> -    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/bindings/swig/include
> >> -    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/bindings/swig
> >> -    ${CMAKE_CURRENT_SOURCE_DIR}/subversion/include
> >> -
> >> -    ${CMAKE_CURRENT_BINARY_DIR}/subversion/bindings/swig/proxy
> >> -    ${CMAKE_CURRENT_BINARY_DIR}
> >> -  )
> >> -
> >>    add_library(external-swig INTERFACE)
> >>
> >>    file(GLOB swig_headers_input 
> >> "${CMAKE_CURRENT_SOURCE_DIR}/subversion/include/*.h")
> >> ]]]
> >>
> >
> > Of course. This patch solves the problem.
> >
> > Do you want to go ahead and commit it or I can do so if you want?
> >
>
> Thanks for the reviewing! Committed in r1933880.

Thanks!

-- 
Timofei Zhakov