Thanks, that is an good explanation! Cheers, Daniel
tis 9 dec. 2025 kl. 19:11 skrev Timofei Zhakov <[email protected]>: > Those are not actually "errors" but new improved behaviour for which the > tests have not been updated yet. > > Basically, what happens there is the test tries to feed > invalid arguments and expects an error, but that branch brings support for > this scenario by switching the command line to UTF-8 entirely. > > PS: My Visual Studio environment exploded so I couldn't fix those tests at > this moment. > > On Tue, Dec 9, 2025 at 7:43 PM Daniel Sahlberg < > [email protected]> wrote: > >> Hi, >> >> These errors seem related to the argv_with_best_fit_chars test in >> basic_tests.py. It was added relatively recent, in r1921371 >> <https://svn.apache.org/r1921371>. >> >> Logs: >> >> 2025-12-09T17:25:24.7813320Z 64: W: EXPECTED STDERR (regexp, >> match_all=False): >> 2025-12-09T17:25:24.8015441Z 64: W: | svn: E721113: >> 2025-12-09T17:25:24.8152759Z 64: W: ACTUAL STDERR: >> 2025-12-09T17:25:24.8633582Z 64: W: | "foo" "bar": unknown command. >> 2025-12-09T17:25:24.8760135Z 64: W: | >> 2025-12-09T17:25:24.9162542Z 64: W: CWD: >> D:\a\subversion\subversion\out\Testing\cmdline.basic_tests\subversion\tests\cmdline >> 2025-12-09T17:25:24.9597413Z 64: W: EXCEPTION: SVNUnmatchedError >> 2025-12-09T17:25:25.0016374Z 64: Traceback (most recent call last): >> 2025-12-09T17:25:25.0124381Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\main.py", line >> 2000, in run >> 2025-12-09T17:25:25.0209177Z 64: rc = self.pred.run(sandbox) >> 2025-12-09T17:25:25.0434033Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\testcase.py", >> line 258, in run >> 2025-12-09T17:25:25.0615573Z 64: return self._delegate.run(sandbox) >> 2025-12-09T17:25:25.0685767Z 64: ~~~~~~~~~~~~~~~~~~^^^^^^^^^ >> 2025-12-09T17:25:25.0761196Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\testcase.py", >> line 178, in run >> 2025-12-09T17:25:25.0798388Z 64: result = self.func(sandbox) >> 2025-12-09T17:25:25.1036250Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\basic_tests.py", line >> 3367, in argv_with_best_fit_chars >> 2025-12-09T17:25:25.1199122Z 64: >> svntest.actions.run_and_verify_svn2(None, expected_stderr, 1, 'help', >> 2025-12-09T17:25:25.1524504Z 64: >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> 2025-12-09T17:25:25.1708218Z 64: >> 'foo{0} {0}bar'.format(wc)) >> 2025-12-09T17:25:25.1988486Z 64: >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> 2025-12-09T17:25:25.2300635Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\actions.py", >> line 399, in run_and_verify_svn2 >> 2025-12-09T17:25:25.2735523Z 64: verify.verify_outputs("Unexpected >> output", out, err, >> 2025-12-09T17:25:25.3013476Z 64: >> ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> 2025-12-09T17:25:25.3081005Z 64: expected_stdout, >> expected_stderr) >> 2025-12-09T17:25:25.3155979Z 64: >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> 2025-12-09T17:25:25.3528748Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\verify.py", >> line 537, in verify_outputs >> 2025-12-09T17:25:25.3596395Z 64: compare_and_display_lines(message, >> label, expected, actual, raisable) >> 2025-12-09T17:25:25.3877582Z 64: >> ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> 2025-12-09T17:25:25.4052445Z 64: File >> "D:\a\subversion\subversion\subversion\tests\cmdline\svntest\verify.py", >> line 510, in compare_and_display_lines >> 2025-12-09T17:25:25.4177425Z 64: raise raisable >> 2025-12-09T17:25:25.4550641Z 64: svntest.main.SVNUnmatchedError >> 2025-12-09T17:25:25.4927636Z 64: FAIL: basic_tests.py 74: argv with best >> fit chars >> >> I don't understand this well enough to really help, just wanted to make sure >> it is on someones radar. >> >> Cheers, >> Daniel >> >> >> >> Den tis 9 dec. 2025 kl 18:03 skrev GitBox <[email protected]>: >> >>> >>> The GitHub Actions job "CMake" on subversion.git/utf8-cmdline-prototype >>> has failed. >>> Run started by GitHub user asf-gitbox-commits (triggered by >>> asf-gitbox-commits). >>> >>> Head commit for run: >>> 5bd5db612536903046f3601659c4cf21ff7f5e69 / Timofei Zhakov < >>> [email protected]> >>> On the 'utf8-cmdline-prototype' branch: UTF8-ize svnversion program. >>> >>> * subversion/svnversion/svnversion.c >>> (includes): Remove svn_utf.h because we no longer use it. >>> (sub_main): Directly convert argv to UTF8 and remove all following >>> convertions. >>> >>> * BRANCH-README.md: Update status. >>> >>> >>> git-svn-id: >>> https://svn.apache.org/repos/asf/subversion/branches/utf8-cmdline-prototype@1930392 >>> 13f79535-47bb-0310-9956-ffa450edef68 >>> >>> Report URL: >>> https://github.com/apache/subversion/actions/runs/20072643516 >>> >>> With regards, >>> GitHub Actions via GitBox >>> >>> > > -- > Timofei Zhakov >
