On Mon, Jun 16, 2025 at 10:23 PM Branko Čibej <br...@apache.org> wrote:
> When building trunk (with autotools and maintainer-mode; to test with > serf-2), I get a lot of warnings like this one: > > .../subversion/svnadmin/svnadmin.c:2598:11: warning: > 'svn_opt_args_to_target_array3' is deprecated [-Wdeprecated-declarations] > 2598 | SVN_ERR(svn_opt_args_to_target_array3(&targets, os, > | ^ > > > These are relatively recent. Policy says that trunk should compile without > warnings in maintainer mode. This is on macOS with clang, there are similar > warnings in the autoconf worflow on GitHub. > > There used to be a warnings-check builder that would fail in such cases, > but apparently it hasn't been ported to GH actions. > > -- Brane > > I think I left them in one of my recent commits, in which I migrated the codebase to use svn_opt_args_to_target_array3 instead of private svn_opt__args_to_target_array. The thing is the whole svn_opt_args_to_target_array() family was completely deprecated, however, as needed, svn_opt__args_to_target_array was utilised instead. This meant that a new version of this function could not be added. And I think it would be wrong to un-deprecate svn_opt_args_to_target_array3, as it was deprecated before. This is my bad for getting the trunk into this kind of transitional state. It's about to change as utf8 cmd-line comes in place, since it bumps the version of this function. I'd suggest one of the following: 1. not worrying that much about the warnings and waiting for utf8 cmdline (I bet it's going to be ready very soonly! There are only several polishing-out things awaiting, and it's ready for review.). ...or... 2. un-deprecate svn_opt_args_to_target_array3 ...or... 3. add svn_opt_args_to_target_array4 doing exactly the same thing as svn_opt_args_to_target_array3, but without the deprecation marker. However, this means that utf8 cmd-line would change this function later or even require svn_opt_args_to_target_array5. None of which look good to me. Thoughts? -- Timofei Zhakov
