[...] > *This* is clearly wrong. If the call to svn_client_patch2 fails, we leak > the file descriptor. That doesn't affect the svn command-line much but it > does affect users of the library. Looking at the whole commit, it appears > that the same bug existed in apply_patches() before your change. >
It should not be leaked because it will be free'd on pool cleanup and even the file will be closed. As far as I can tell Subversion relies on this behaviour quite frequently. -- Timofei Zhakov
