On Fri, Feb 21, 2025 at 10:58 AM Mark Phippard <markp...@gmail.com> wrote:
>
> On Fri, Feb 21, 2025 at 10:56 AM Daniel Sahlberg
> <daniel.l.sahlb...@gmail.com> wrote:
> >
> > Den fre 21 feb. 2025 kl 14:13 skrev Mark Phippard <markp...@gmail.com>:
> >>
> >> The workflow should be updated to upload all logs as build aritfacts.
> >> You can then download them when needed from GitHub:
> >>
> >> https://github.com/marketplace/actions/upload-a-build-artifact
> >>
> >> Since you need the logs even if build fails you need to make sure you
> >> set up that step of the workflow to always run. Something like this:
> >>
> >>
> >> - name: Archive Build Logs
> >> if: always()
> >> uses: actions/upload-artifact@v4
> >> with:
> >> name: build-logs
> >> path: logs/
> >>
> >>
> >
> > Tried my best in r1923964. There is a high chance I've messed things up
> > (artifact name must be unique, but documentation isn't clear if it is
> > across the whole workflow or within the specific matrix cell; also not sure
> > what the `cwd` is with regards to the name).
> >
> > If it fails, I'll follow up shortly.
>
> The cwd, is the root of the working copy.
>
> The name only has to be unique within the context of that running
> workflow. Imagine you were uploading the logs in one step, test
> results in another and a tar.gz of the binaries in another. Each of
> those needs to have a unique name which is largely for display in the
> UI
>
> IOW, a name like "logs" is likely fine.
I noticed the matrix part as I clicked send.
You probably name to be something like ${{ matrix.check-target }}-logs
Mark
