Timofei Zhakov
On Sun, 29 Dec 2024 at 4:00 PM, Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > Den tis 24 dec. 2024 kl 18:26 skrev Timofei Zhakov <t...@chemodax.net>: > >> >> Hi Daniel, >> >> Thanks for this feedback, but probably you didn't fully get this commit. >> This is a fix to a stupid bug that I made in the commit, that I follow-up >> to. In r1921602 I've introduced a new argument to the function >> (use_git_diff_format). Before, it was always defaulting to FALSE. In that >> revision, you may notice a change, presented below in this function: >> > > [...] > > Oh, sorry, I missed that part. I thought I looked through all history but > obviously not. > > You are absolutely right, this change is correct (and the other related > changes also look good). > (I agree that they still make some confusion, because of the huge amount of follow-ups and fixes) > Cheers, > Daniel > >
