[...] > >> This patch seems to be working and it resolves the issue. I think it's > >> okay to commit it. Would you like to do it, or should I commit it? > > Thanks for the reviewing! Committed in r1920764.
Nice! Thanks! > > > I have an additional resolution to the problem: > > > > I think those three functions are the last, where the opening brackets > > are placed on a new line, separate from the function name. How about > > reformatting them to match the style used in other functions? > > Additionally, their implementations have the opening brackets on the > > same line as the function name. > > > > I’ve attached a patch as svn-fix-declaration-wrapping.patch.txt. > > Reformatting is okay to me. Also, the following functions have the same issue: > > [[[ > $ grep -Pzo -r --include='*.h' '\b(svn|apr)_[A-Za-z0-9_]+\s*\n(?=\s*\()' > subversion > subversion/include/svn_auth.h:svn_auth_get_gpg_agent_simple_provider > subversion/libsvn_subr/auth.h:svn_auth__get_gpg_agent_simple_provider > subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:svn_swig_pl_thunk_ssl_server_trust_prompt > subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:svn_swig_pl_thunk_ssl_client_cert_prompt > subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:svn_swig_pl_thunk_ssl_client_cert_pw_prompt > subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h:svn_swig_rb_conflict_resolver_func > ]]] Thank you for making this list. Will commit the reformatting soon. -- Timofei Zhakov
