Merged in revision 1920717! On Sat, Sep 14, 2024 at 3:17 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > > Den lör 14 sep. 2024 kl 14:46 skrev Timofei Zhakov <t...@chemodax.net>: >> >> Hi, >> >> I've made some progress with the CMake build: >> >> 1. It now works perfectly across different platforms. >> 2. I've added the running of test suites, including Python tests and C tests. >> 3. SWIG bindings have been included. >> 4. NLS (localization) support has been added. >> 5. Modules for the Apache HTTP Server are now compiled. >> 6. Many other small improvements have been made. > > > Excellent work! It has been a joy to follow your progress! =) > >> I think the CMake branch is now ready to be merged into the trunk. I >> am going to proceed with this, assuming there are no objections. > > > I agree that it is the correct next step. It might be beneficial to try to > make a comparison between the CMake build system and the old build system to > know what minor features we are missing, but that should not be a > prerequisite for merging, just for the future to help us decide when/if we > switch to CMake as the "default" build system. > > For my part, I've promised to have a look at JavaHL bindings. I came part of > the way last time I looked but run out of time and have not been able to > prioritize it and since it was partly broken I didn't want to commit it > half-baked it to the CMake branch to ruin everyone else's effort. Maybe if we > merge to trunk we can then use the CMake branch as a more "unstable" branch > for the missing bits and pieces while doing maintenance work on trunk?
It's an interesting idea to use that branch as more "unstable". However, I think that it's better to create new branches for implementing new features like JavaHL, or do them in 'trunk' directly. >> >> >> Of course, I will continue to improve the CMake build after it has >> been merged into the trunk. >> >> My next goal is to setup continuous integration using GitHub Actions >> for the CMake build to see how it works with different platforms and >> configurations. > > > That would be very good! > > Kind regards, > Daniel > -- Timofei Zhakov
