Just a small nit, with the intention to limit variable scope.
Den lör 17 aug. 2024 kl 16:38 skrev <rin...@apache.org>:
> -def get_output_name(name):
>
- if name.startswith("lib"):
> - return name[3:] + "-1"
> +def get_output_name(target):
> + if target.name.startswith("lib"):
> + return target.name[3:] + "-1"
> + elif isinstance(target, gen_base.TargetSWIG):
> + module_name = target.name[len(target.lang + "_"):]
>
Is there a need to calculate module_name here?
> + if target.lang == "python":
>
Why not just here
> + return module_name
>
or even just:
return target.name[len(target.lang + "_"):]
> + else:
> + return target.name
Cheers,
Daniel
