Hi, One question on the SQLiteAmalgamation code.
There is currently a configuration option to request to use an amalgamation for SQLite (SVN_SQLITE_USE_AMALGAMATION), defaulting to ON. If you don't have an amalgamation downloaded (in the sqlite-amalgamation directory), configuration will fail unless you set the option to OFF. The old ./configure script had the logic to use the amalgamation if available or else check for a library. Is there a reason for defaulting to the amalgamation and requiring an explicit option to NOT use it? With something like below, it seems the build would check for the amalgamation and use it if found and otherwise check for a library. [[[ Index: CMakeLists.txt =================================================================== --- CMakeLists.txt (revision 1919836) +++ CMakeLists.txt (working copy) @@ -228,8 +228,8 @@ ### SQLite3 -if(SVN_SQLITE_USE_AMALGAMATION) - find_package(SQLiteAmalgamation REQUIRED) +find_package(SQLiteAmalgamation) +if(SQLiteAmalgamation_FOUND) add_library(external-sqlite ALIAS SQLite::SQLite3Amalgamation) else() find_package(SQLite3 REQUIRED) ]]] WDYT? Kind regards, Daniel
