Den sön 28 juli 2024 kl 20:00 skrev Stefan Sperling <s...@apache.org>:

> On Fri, Jul 26, 2024 at 10:41:14PM +0200, Daniel Sahlberg wrote:
> > I also tried OpenBSD but failed on missing Expat ("Could not find a
> package
> > configuration file provided by "expat" with any of the following names:
> > expatConfig.cmake expat-config.cmake [....]". I could not figure out if
> > this is a missing package in OpenBSD or that Expat on OpenBSD doesn't
> > provide the required cmake file. I hope @Stefan Sperling <
> s...@apache.org>
> > can chime in on this issue!
>
> The expat library is part of openbsd base + comp installation sets.
> Any default install will have it.
>
> There is a pkg-config file: /usr/lib/pkgconfig/expat.pc
>
> cmake needs to be installed with pkg_add, and a FindEXPAT.cmake module
> is part of the cmake package. Does this help?
>
> Contents of FindEXPAT.cmake listed below:
>

[cut]

Thank you Stefan, that helped a lot.

CMake is far from my comfort zone but I've tested the following change and
it seems to work on both OpenBSD and Ubuntu 24.04:

[[[
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt      (revision 1919555)
+++ CMakeLists.txt      (working copy)
@@ -174,8 +174,8 @@

 ### EXPAT

-find_package(expat CONFIG REQUIRED)
-add_library(external-xml ALIAS expat::expat)
+find_package(EXPAT REQUIRED)
+add_library(external-xml ALIAS EXPAT::EXPAT)

 ### LZ4

@@ -481,7 +481,7 @@
 message(STATUS "  Dependecies:")
 message(STATUS "    APR ........................... : ${APR_VERSION}")
 message(STATUS "    APR-Util ...................... : ${APRUTIL_VERSION}")
-message(STATUS "    EXPAT ......................... : ${expat_VERSION}")
+message(STATUS "    EXPAT ......................... :
${EXPAT_VERSION_STRING}")
 message(STATUS "    ZLIB .......................... : ${ZLIB_VERSION}")
 message(STATUS "    LZ4 ........................... : ${lz4_VERSION}")
 message(STATUS "    UTF8PROC ...................... : ${UTF8PROC_VERSION}")
]]]

@Timofei, does this make sense? Notably, does it work on Windows?

Kind regards,
Daniel

Reply via email to