On Sat, Jul 6, 2024 at 7:57 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > > Just a minor nit! > > Den lör 6 juli 2024 kl 14:27 skrev <rin...@apache.org>: >> >> Author: rinrab >> Date: Sat Jul 6 12:27:21 2024 >> New Revision: 1918965 >> >> URL: http://svn.apache.org/viewvc?rev=1918965&view=rev >> Log: >> On the 'cmake' branch: Read and setup Subversion package version. >> >> * CMakeLists.txt >> (version): Do little magic with CMake and regexes to read the version. >> (project): Setup VERSION field. >> >> Modified: >> subversion/branches/cmake/CMakeLists.txt > > > This also seems to add an option to build SVNXX: > > @@ -83,6 +96,8 @@ if(SVN_BUILD_SHARED_RA) >> >> message(FATAL_ERROR "SVN_BUILD_SHARED_RA not yet supported") >> endif() >> >> +option(SVN_BUILD_SVNXX "Enable compilation of the C++ bindings (requires >> C++)" OFF) >> + >> # Setup modules path >> >> list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/build/cmake") > > > Should be mentioned in the log message, I think. > > Kind regards, > Daniel >
Hello, Thanks for the notice! I was experimenting with SVNXX and forgot to revert this change :) Reverted in revision 1918977. -- Timofei Zhakov
