Den tis 21 maj 2024 kl 15:39 skrev Timofey Zhakov <t...@chemodax.net>:
> Thank you for reasoning your point. > > After doing additional research, I found that the `rulers` is used > less, so I decided to not add it. > > I updated the patch and log message. For sure I included details about > support in different editors to the code and log message. > > [[[ > Specify guidelines and max_line_length properties from the EditorConfig. > > Set the `guidelines` and `max_line_length` properties to 79 symbols from > the > EditorConfig file. These properties are not commonly supported by editors > [1], > [2]. The value `79 symbols` is described in the community guidelines, so > these > properties in the EditorConfig file would help us to follow the rule. > > [1] The `max_line_length` property is supported by Emacs, Vim, Neovim, > Atom, > JetBrains IDEs, Kakoune, and Prettier. > > [2] The `guidelines` property is supported by Visual Studio with > EditorConfig Guidelines or Editor Guidelines extensions. > > * .editorconfig: > (guidelines, max_line_length): Set these properties to 79 symbols. > ]]] > Dear Timofey, Thanks for the patch and I'm sorry it took me so long to find the time to review it. I initially had problems getting it to work at all and I can't get Emacs to behave but it works as expected on Vim som I'm going to count this a success. Committed this as r1918362. Kind regards, Daniel > > > On Tue, May 21, 2024 at 9:22 AM Daniel Sahlberg > <daniel.l.sahlb...@gmail.com> wrote: > > > > Den mån 20 maj 2024 kl 18:53 skrev Timofey Zhakov <t...@chemodax.net>: > >> > >> Hello, > >> > >> Thank you for rapid response, > >> > >> On Mon, May 20, 2024 at 6:16 PM Daniel Sahlberg > >> <daniel.l.sahlb...@gmail.com> wrote: > >> > > >> > Hi > >> > > >> > I can find very little information about the guidelines keyword. > >> > > >> > Is this a widely supported option in .editorconfig or is it something > specific to a certain IDE or even a certain plugin? In case of the latter I > think it should be mentioned in the commit message. > >> No, this keyword is not that much supported. I have a Visual Studio > >> extension which provides support for this rule. > > > > > > Thanks for the expanation! > > > >> > >> > >> > > >> > Is the max_line_length a better option? > >> There are also some three common keywords for this rule: guidelines, > >> max_line_length, and rulers. Can we add them all? > > > > > > Why not? > > > >> > >> Do you agree with this if I mention details in the log message? > > > > > > Sure! The reason I suggest to have it in the log message is if someone > down the road looks at the file and things "but guidelines isn't an > editorconfig option..?", then it helps to look at blame and see "ah, it was > for Visual Studio extention XYZ". > > > >> > >> With best regards, > >> Timofei Zhakov > > > > -- > Timofei Zhakov >
