Den sön 28 apr. 2024 kl 16:07 skrev Khairul Azhar Kasmiran <
kaza...@gmail.com>:

> > Committed in r1917397.
>
> Hi Daniel, the indentation is somehow off [1]. My editor is showing
> that there are tabs there (in attached image).
>

Doh. Used the wrong tool for the job. Fixed in r1917405.

Thanks for noticing
/Daniel



>
> [1]
> https://github.com/apache/subversion/commit/014bf1137790e38c5d9a9ebcaa8eae37a952e720#diff-a8f344ecc1feeea3eae75bf0bdce5784cb1c945e8748015d7d1c4a42e61c8f9e
>
> -- Khairul
>
> On Sun, Apr 28, 2024 at 4:23 PM Daniel Sahlberg
> <daniel.l.sahlb...@gmail.com> wrote:
> >
> > Den sön 28 apr. 2024 kl 04:18 skrev Khairul Azhar Kasmiran <
> kaza...@gmail.com>:
> >>
> >> Hi everyone!
> >>
> >> Following on from [1], this patch prevents the error "a peg revision
> >> is not allowed here" when svn_apply_autoprops.py handles filenames
> >> containing `@`. Stack Overflow [2] gives the impression that these
> >> filenames are rare -- I have them because I have code that works with
> >> npm type packages like [3].
> >>
> >> The patch still appears routine to me, but maybe I've put the fix in
> >> the wrong place or something like that.
> >>
> >> [1] https://lists.apache.org/thread/k0o0ytr6h74wf92p4xyg8tvq5g7h4tj7
> >> [2]
> https://stackoverflow.com/questions/757435/how-to-escape-characters-in-subversion-managed-file-names
> >> [3] https://www.npmjs.com/package/@types/node
> >>
> >> [[[
> >> svn_apply_autoprops.py: Support @-containing filenames.
> >>
> >> * contrib/client-side/svn_apply_autoprops.py
> >>   (filter_walk): Append `@` to filenames containing `@`.
> >> ]]]
> >
> >
> > Thanks, I've tested and it seems to work fine. Committed in r1917397.
> >
> > Kind regards,
> > Daniel
> >
> >>
> >>
> >> Best regards,
> >> Khairul
>

Reply via email to