On Fri, Oct 13, 2023 at 12:42:27AM -0500, Greg Stein wrote: > Hey all, > > So I'm looking at incorporating a couple key svn-mailer (by Andre Malo) > features into mailer.py. Specifically, the body-length limit and mail > encoding, and in turn deferring to viewvc links to replace what would be > large emails. > > The py3 work was done by stsp and futatuki, so I ask them specifically, and > the community in general: do we have any guarantees on *internal* > interfaces of the mailer.py script? Do we know of any users that import > that script and use its functions/classes? In other words, is there an > implied API to maintain guarantees for? > > If the answer is "no", then I'd prefer to change the dataflow for rendering > and its write(_binary) mechanism. > > Thoughts?
I have only seen cases where mailer.py is invoked with its command line via a hook script. And I would say if anyone reached into internals they will well be able to deal with updates that break things for them and adapt their code. It's not going to be a hugely complicated effort for them. We never promised such compatibility in the first place, as far as I know. Cheers, Stefan