Den sön 11 juni 2023 kl 16:00 skrev Bert Huijben <b...@qqmail.nl>:

> Those functions are not exported from the dll on Windows, -only specific
> marked functions are, ulike unix where we export everything- so a
> workaround was needed to access those functions from our test suite.
>
>
> This patch will break testing on Windows, but with +- all the buildings
> down for different forms of maintenance nobody notices.
>
> The old issue was test only, and I don't think just breaking all WC test
> on Windows just for build sanityvreasond is a proper fix. This will need a
> proper fix to allow release testing on Windows again.
>
> Bert
>

Thanks for the ping!

+1 on the above.

I think it would be best if the original author of this revision could look
at this instead of just reverting. In lack of reply I'd suggest we revert
this by the end of the week: @Jun Omae <jun6...@gmail.com> can you do this
since you also have the test cases?

Kind regards,
Daniel

Reply via email to