Den mån 29 maj 2023 kl 02:13 skrev Jun Omae <jun6...@gmail.com>: > Hi, > > On Fri, Apr 14, 2023 at 6:09 AM Daniel Sahlberg > <daniel.l.sahlb...@gmail.com> wrote: > > I have committed a fix as r1909127. > > > > Kind regards, > > Daniel > > Added 2 tests to copy_tests.py in r1909127 failed on Windows: > > [[[ > FAIL: copy_tests.py 16: move URL URL/subdir > FAIL: copy_tests.py 17: move WC WC/subdir > ]]] > > See attached dav-fails.log. >
For test 16: [[[ W: Unexpected output W: EXPECTED STDERR (regexp, match_all=False): W: | svn: E200007: Cannot move path '.* http://localhost:17838/svn\-test\-work/repositories/copy_tests\-16/A/B' into its own child '.* http://localhost:17838/svn\-test\-work/repositories/copy_tests\-16/A/B/F' W: ACTUAL STDERR: W: | svn: E200007: Cannot move path 'http:\\localhost:17838\svn-test-work\repositories\copy_tests-16\A\B' into its own child 'http:\\localhost:17838\svn-test-work\repositories\copy_tests-16\A\B\F' ]]] There was a call to svn_dirent_local_style on the error message, which obviously turned \ to / on Windows. I've added a check in r1910112, please check if this works for you. For test 17: [[[ File "C:\usr\apps\python312\Lib\re\_parser.py", line 383, in _escape raise source.error("incomplete escape %s" % escape, len(escape)) re.error: incomplete escape \u at position 34 ]]] I suppose this is because the expected_error is constructed like this: [[[ expected_error = "svn: E200007: Cannot move path '%s' into its own " \ "child '%s'" % (from_path, to_path) ]]] With a from_path C:\usr\subversion\[...], I suppose Python interpret \ as an escape character. I'm not proficient enough in Python to have an idea of how to escape from_path and to_path in an appropriate way. @Jun, do you have a suggestion? (Sidenote: There is an error message in the test log about line 1424. This was added way back in r846892 and has essentially been unchanged ever since. I believe this is unrelated and I will send this in a separate thread when I've had some more time to look at it). Kind regards, Daniel
