Daniel, et. al.: On Mon, Jan 2, 2023 at 5:14 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote:
> In a thread started by Vincent Lefevre in October [1] it was noted that > Subversion prints several pieces of information from the repository to the > terminal (including log messages and author names) without considering if > they may affect terminal behaviour. > > As demonstrated by DanielSh [2] a user may inject escape sequences into a > log message and when running svn log, these affect terminal color. Git > behaves the same way, as demonstrated by me [3]. > Any idea what Git is going to do with this? > Can we reach consensus if this behaviour is intended, unintended but > desirable or unintended and undesirable? I would value the opinions of the > oldtimers who might have background information if this was ever discussed > or considered in the early days. > > In the original thread there were several arguments both pro and con > regarding filtering/quoting escape sequences. > >From my perspective trying to do anything about this is opening up a huge investigation that may result in incompatible-with-history choices. 1. What about "svn diff" ? (any modifications here could break "patch", et. al.) 2. What about "svn cat" ? 3. What about properties? (I just verified you can place escape sequences in them). ... (I doubt my list above is complete.) A "complete" implementation of a "feature" to mask/protect-against escape sequences is also going to need an option to enable the raw output (including the escape sequences) for every command/context where they could be coming out today. The reason is that somebody out there has possibly used that "feature" as a "capability" to automate something. Preventing the output now would completely break whatever automation they cooked up. And it is unlikely that anyone inheriting that automation will understand it enough AND be reading this thread to object. Changing the default behavior is also something that could be argued to be breaking change requiring a "major number" to get bumped (e.g. a new release - not a patch)... Just some thoughts. Doug -- <https://wandisco.com/> THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED If this message was misdirected, WANdisco, Inc. and its subsidiaries, ("WANdisco") does not waive any confidentiality or privilege. If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone. Any distribution, use or copying of this email or the information it contains by other than an intended recipient is unauthorized. The views and opinions expressed in this email message are the author's own and may not reflect the views and opinions of WANdisco, unless the author is authorized by WANdisco to express such views or opinions on its behalf. All email sent to or from this address is subject to electronic storage and review by WANdisco. Although WANdisco operates anti-virus programs, it does not accept responsibility for any damage whatsoever caused by viruses being passed.
