Evgeny, Thanks so much for your hard work in pushing this project forward!
I don't think I can contribute much in getting this merged to trunk (from lack of C experience and lack of time to dig into the inner workings), but I hope it can be completed! Kind regards, Daniel Sahlberg Den ons 7 dec. 2022 kl 18:10 skrev Evgeny Kotkov via dev < dev@subversion.apache.org>: > Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes: > > > > IMHO, once the tests are ready, we could merge it and release > > > it to the world. > > > > Apart from the required test changes, there are some technical > > TODOs that remain from the initial patch and should be resolved. > > I'll try to handle them as well. > > I think that the `pristines-on-demand-on-mwf` branch is now ready for a > merge to trunk. I could do that, assuming there are no objections. > > > https://svn.apache.org/repos/asf/subversion/branches/pristines-on-demand-on-mwf > > The branch includes the following: > – Core implementation of the new mode where required pristines are fetched > at the beginning of the operation. > – A new --store-pristine=yes/no option for `svn checkout` that is persisted > as a working copy setting. > – An update for `svn info` to display the value of this new setting. > – A standalone test harness that tests main operations in both > --store-pristine modes and gets executed on every test run. > – A new --store-pristine=yes/no option for the test suite that forces all > tests to run with a specific pristine mode. > > The branch passes all tests in my Windows and Linux environments, in both > --store-pristine=yes and =no modes. > > > While here, I would like to raise a topic of incorporating a switch from > SHA1 to a different checksum type (without known collisions) for the new > working copy format. This topic is relevant to the pristines-on-demand > branch, because the new "is the file modified?" check relies on the > checksum > comparison, instead of comparing the contents of working and pristine > files. > > And so while I consider it to be out of the scope of the > pristines-on-demand > branch, I think that we might want to evaluate if this is something that > should be a part of the next release. > > > Thanks, > Evgeny Kotkov >
