On Wed, Sep 21, 2022 at 5:51 AM Bert Huijben <b...@qqmail.nl> wrote: > > File externals didn't exist in the entry world, so you can ignore that edge > case. Older code will just detect them as a switched path which is fine, as > that is essentially what they are anyway. > > Normal (directory) externals should be mapped, but I assume they already are > or we would have found these earlier on in the WC-NG migration. > > The lock flag is seldom tested, nor seen from testcode as it would imply the > working copy is broken by some operation.... If we have such a testcase, we > usually fix the real issue instead of increasing test coverage. > (The issue was far more common pre WC-NG, where we didn't have true recursive > operations... so we had to lock on many levels separately)
Thank you for this explanation. Knowing this, I am OK to commit the 'locked' fix without trying to add a specific test case for it. Committed in r1904193. Nominated for backport, with your vote, in 1904194. I'll leave the file_external flag alone for now. Cheers, Nathan
