On 2022/09/19 11:37, Vincent Lefevre wrote: > On 2022-09-19 11:02:05 +0900, Yasuhito FUTATSUKI wrote: >> I can't determine whether this behavior is a bug or not. >> >> As svn_cl__propedit() calls svn_cmdline__edit_string_externally()[1] >> for editing revprop value string with the parameter tempfail_reft is >> NULL[2], the temporary file is removed within the function >> svn_cmdline__edit_string_externally(), before trying to set the new >> value. So, it can be reproduced in any scheme, even "file" scheme, >> by rejecting the change of revprop values in pre-revprop-change >> hook. > > Well, if the pre-revprop-change hook rejects the change, this may > not be a bug, though I think that the new file should really be kept > somewhere. AFAIK, the svn-commit.tmp file (log message) is kept for > a rejected commit, so I don't see why this should be different. > > But here, this is not a rejection due to a hook, but a failure due to > some external cause, on which the user has no control (contrary to a > hook).
Ah, second paragraph is not the reason why I can't see that it is bug or not. It is just I don't see why the author wrote a such code. I am still neutral. I wrote the second paragraph just for to show where the behaivor comes from, i.e. where to fix, who want to fix it, and for there information to write a regression test. Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
