On Sat, Aug 20, 2022 at 7:24 PM Vincent Lefevre <vincent-...@vinc17.net> wrote: > > On 2022-08-20 14:08:43 +0200, Branko Čibej wrote: > > On 20.08.2022 00:57, Vincent Lefevre wrote: > > > A minor issue I had found during my checks for the URL update: > > [...] > > > Shouldn't build/generator/templates/vcnet_vsprops.ezt have > > > svn:eol-style set to native so that it doesn't get CRLF > > > line terminators under Unix? > > > > > > Similarly, .bat files have inconsistent svn:eol-style properties: > > > > Actually no, both should have CRLF line endings enforced. .bat files > > certainly should, at least once upon a time they would otherwise be invalid > > on Windows. For the .vcproj etc (XML) files, I'm not sure whether > > VisualStudio still cares, but the .properties, IIRC are treated differently? > > So, shouldn't CRLF line endings be enforced for *all* .ezt and .bat files?
For all *.bat files, I think CRLF should be enforced. But not for all *.ezt. Some, perhaps, but not all. The .ezt files are templates used for various purposes. For example, while build/generator/templates/build_locale.ezt is a template for a DOS batch file, others such as (I'm picking one at random--it wasn't in your list) tools/dist/templates/release-notes-lts.ezt are templates for other file types (HTML in this particular case). So perhaps relevant .ezt files should be changed to CRLF where appropriate, depending on their content. This makes me wonder, though, how EZT [1] (the program that processes these templates) generates its output. Does it output the same line endings as found in the templates? Or does it unconditionally output "\n" endings when run on Unix and "\r\n" endings when run on Windows, regardless of the template's line endings? I haven't checked, but the answer to this question will strongly influence how the line endings of *.ezt files should be. [1] https://github.com/gstein/ezt Cheers, Nathan
