On Thu, Jul 14, 2022 at 3:55 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > > Thanks for the review. I've committed a few changes as r1902722. More below. > > Den ons 13 juli 2022 kl 15:57 skrev Daniel Shahaf <d...@daniel.shahaf.name>: >> >> dsahlb...@apache.org wrote on Fri, Jul 08, 2022 at 20:47:42 -0000: >> > +++ subversion/trunk/tools/dist/release.py Fri Jul 8 20:47:42 2022 >> > @@ -980,7 +979,12 @@ def roll_tarballs(args): >> > # from a committer's LDAP profile down the road) >> > basename = 'subversion-%s.KEYS' % (str(args.version),) >> > filepath = os.path.join(get_tempdir(args.base_dir), basename) >> > - download_file(KEYS, filepath, None) >> > + # The following code require release.py to be executed within a >> > + # complete wc, not a shallow wc as indicated in HACKING as one >> > option. >> > + # We /could/ download COMMITTERS from /trunk if it doesn't >> > exist... >> >> Well, could you please either change HACKING or download COMMITTERS? >> The code for the latter is basically the tempfile+urlopen mechanics from >> the next hunk of this very diff. > > > I prefer to have less variations in the process to make it easier for new > RMs. I've removed this from HACKING in r1902723 (only on site/staging so far).
Thanks for doing that. I had intended to draft some changes for HACKING but it ended up being a busier week than I had anticipated. Nathan
