On Sun, May 15, 2022 at 6:21 AM Daniel Shahaf <d...@daniel.shahaf.name> wrote:
>
> Nathan Hartman wrote on Sun, May 15, 2022 at 03:36:05 -0400:
> > On Sat, May 14, 2022 at 8:57 AM <danie...@apache.org> wrote:
> > > +++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
> > > @@ -39,6 +39,15 @@ Candidate changes:
> > >     votes:
> > >       +1: rhuijben
> > >
> > > + * r1900882
> > > +   Replace a call to a function deprecated upstream.
> > > +   Justification:
> > > +     No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to 
> > > be
> > > +     built by future Python 3.12.  Note that Python 3.2 was released 9 
> > > years
> > > +     before Subversion 1.14.0.
> > > +   Votes:
> > > +     +1: danielsh
> > > +
> >
> > Should futatuki's follow-up in r1900890 be added to this nomination?
>
> Per <https://subversion.apache.org/docs/release-notes/1.14#python2>,
> breaking py2 support in a 1.14.x patch release is permitted.  Thus,
> we are not required to add r1900890 to this nomination.

Agreed. I asked just in case you missed it.

> If we do nominate r1900890, here's my +0 for it.  (Not +1 because
> I haven't audited all callsites that «import gen_base».)

Understood. Thanks.

> > Also should this reference SVN-4899?
>
> r1900922.

Thanks for adding that.

Cheers,
Nathan

Reply via email to