On 18.04.2022 19:46, Nathan Hartman wrote:
On Sun, Apr 17, 2022 at 9:30 AM <danie...@apache.org> wrote:
Author: danielsh
Date: Sun Apr 17 13:30:40 2022
New Revision: 1899945
URL: http://svn.apache.org/viewvc?rev=1899945&view=rev
Log:
* subversion/tests/cmdline/__init__.py
(): Rewrite a comment.
Modified:
subversion/trunk/subversion/tests/cmdline/svntest/__init__.py
Modified: subversion/trunk/subversion/tests/cmdline/svntest/__init__.py
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/__init__.py?rev=1899945&r1=1899944&r2=1899945&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/svntest/__init__.py (original)
+++ subversion/trunk/subversion/tests/cmdline/svntest/__init__.py Sun Apr 17
13:30:40 2022
@@ -18,8 +18,6 @@
# under the License.
#
-# any bozos that do "from svntest import *" should die. export nothing
-# to the dumbasses.
__all__ = [ ]
import sys
This removes the comment, rather than rewriting it as suggested in the log.
I agree the comment should be rewritten. It was added (along with the
__all__ = []) in r951379, the log of which reads: "Protect against bad
python proggies." I couldn't find other contextual information about
it, but I suppose any comment to that effect would be helpful?
'from X import *' is considered bad practice in Python, for various reasons.
I'm not sure why the comment had to be removed, unless it's a case of
overly sensitive political correctness.
-- Brane
