[[[
r1891073 | dsahlberg | 2021-06-27 03:44:18 -0400 (Sun, 27 Jun 2021) | 70 lines

In site/staging-ng: Mobile friendlier website
]]]

Thanks for doing this!

Code changes look good; I need to install httpd etc again to see how
it actually looks, so feedback on that later... Meanwhile, only a
couple of minor nits below...

[[[
Index: site-nav.html
===================================================================
--- site-nav.html (revision 1891072)
+++ site-nav.html (revision 1891073)

(snip)

-<div id="site-search">
+<p id="site-search">
   <form action="https://www.google.com/search"; method="get"
         style="margin-top: 10px; margin-bottom: 10px; display: inline;">
   <div style="display: inline;">
@@ -58,24 +57,24 @@
     <input name="Search" value="Go" type="submit"/>
   </div>
   </form>
-</div> <!-- #site-search -->
+</p>
]]]

Recommend to keep the <!-- #site-search --> comment at the </p> tag.

[[[
Index: style/site.css
===================================================================
--- style/site.css (revision 1891072)
+++ style/site.css (revision 1891073)
@@ -61,9 +61,10 @@
 */

 #site-banner {
-  height: 100px;
   padding: 8px;
   background: white url("/images/banner-gradient.jpg") repeat-x;
+  background-attachement: fixed;
+  background-position: bottom;
 }
]]]

"background-attachement": intended to be "background-attachment"?

Cheers,
Nathan

Reply via email to