On Tue, Apr 20, 2021 at 5:02 PM Daniel Shahaf <danie...@apache.org> wrote:
>
> Nathan Hartman wrote on Tue, Apr 20, 2021 at 16:07:58 -0400:
> > On Tue, Apr 20, 2021 at 3:29 PM Daniel Shahaf <danie...@apache.org>
wrote:
> > > (Aside: those <h4/>'s don't have the self-link pilcrows that all
other <h{1..4}/>'s do.)
> >
> > Good catch! That's fixed in r1889033 now :-)
>
> Thank you!
>
> I have now looked for other instances of this omission:

Thanks!


> % ag -B1 '<h\d'  | grep -xv -- '--' | vim -    # and run
'g/class="h\d/.,+d' interactively

As you suspected, this does produce some false positives by triggering
on the blank line preceding a heading (as well as a few that aren't
heading tags). However the results are still useful as it did correctly
locate numerous actual missing pilcrows.

I left the h1's alone as they are page titles and therefore (I think)
they don't need section links.

Detail of changes:


>      8  roadmap.html:137:<h3>Transition to LTS and Regular Releases</h3>
>    176  docs/community-guide/issues.part.html:413:<h3>Security approach
in Subversion's Design and Implementation</h3>
>    178  docs/community-guide/issues.part.html:427:<h3>Handling reported
security vulnerabilities</h3>
>    180  docs/community-guide/issues.part.html:443:<h4>Mailing Lists</h4>
>    182  docs/community-guide/issues.part.html:451:<h4>Tracking Issues</h4>
>    184  docs/community-guide/issues.part.html:459:<h4>Procedures We
Follow</h4>
>    128  docs/release-notes/1.1.html:20:<h2 style="text-align:
center">(and State of the Project)</h2>
>    130  docs/release-notes/1.1.html:29:<h3>Overview</h3>
>    132  docs/release-notes/1.1.html:40:<h3>Compatibility Concerns</h3>
>    134  docs/release-notes/1.1.html:66:<h3>New Major Features</h3>
>    136  docs/release-notes/1.1.html:68:<h4>Non-database repositories
(<em>new server feature</em>)</h4>
>    138  docs/release-notes/1.1.html:95:<h4>Symlink versioning (<em>new
client feature</em>)</h4>
>    140  docs/release-notes/1.1.html:112:<h4>Client follows renames
(<em>new client feature</em>)</h4>
>    142  docs/release-notes/1.1.html:126:<h4>Command line auto-escaping of
URI and IRIs (<em>new client
>    144  docs/release-notes/1.1.html:146:<h4>Localized messages  (<em>new
client feature</em>)</h4>
>    146  docs/release-notes/1.1.html:165:<h3>Other Improvements</h3>
>    148  docs/release-notes/1.1.html:167:<h4>Speed optimizations:
(<em>requires both new client and server</em>)</h4>
>    150  docs/release-notes/1.1.html:171:<h4>Shareable working copies:
(<em>client fix</em>)</h4>
>    152  docs/release-notes/1.1.html:179:<h4>New 'store-passwords' runtime
variable:  (<em>new client feature</em>)</h4>
>    154  docs/release-notes/1.1.html:187:<h4>Bugfixes:</h4>
>    156  docs/release-notes/1.1.html:192:<h4>New subcommand switches:</h4>
>    158  docs/release-notes/1.1.html:239:<h3>Developer Changes</h3>
>    160  docs/release-notes/1.1.html:254:<h3>Testimonials and Roadmap</h3>

Fixed in r1889186 and r1889188.


>     93  security/index.html:36:<h2 id="advisories">Previous Security
Advisories

Fixed missing div around the section. This caused the heading, rather
than the section, to be highlighted when the section link was visited.

Detail of non-changes:


>     38  faq.html:29:<h4>General questions:</h4>
>     40  faq.html:68:<h4>How-to:</h4>
>     42  faq.html:152:<h4>Troubleshooting:</h4>
>     44  faq.html:263:<h4>Developer questions:</h4>
>     46  faq.html:275:<h4>References:</h4>
>     61  faq.html:4483:<h4>Troubleshooting:</h4>
>     63  faq.html:4491:<h4>BDB questions:</h4>
>     26  faq.zh.html:30:<h4>常见问题:</h4>
>     28  faq.zh.html:54:<h4>如何使用:</h4>
>     30  faq.zh.html:99:<h4>疑难解答:</h4>
>     32  faq.zh.html:158:<h4>开发者问题</h4>
>     34  faq.zh.html:165:<h4>说明:</h4>
>     67  faq.ja.html:30:<h4>General questions:</h4>
>     69  faq.ja.html:53:<h4>How-to:</h4>
>     71  faq.ja.html:95:<h4>Troubleshooting:</h4>
>     73  faq.ja.html:143:<h4>Developer questions:</h4>
>     75  faq.ja.html:150:<h4>References:</h4>

The above are part of the FAQ TOC, which has an explicit comment: "no
'id' or 'title' attribute for TOC" so I'm leaving them as-is.


>     48  faq.html:765:<h3>How is Subversion affected by SHA-1 hash
collisions?
>    121  docs/release-notes/1.10.html:1070:<h4>RA-serf now compresses
deltas when possible

False positive due to extra anchors for compatibility with older IDs.


>     50  faq.html:3958:<h3>When performing Subversion operations
>     52  faq.html:4004:<h3>After importing files to my repository,
>     54  faq.html:4042:<h3>When does <tt>svn copy</tt> create
<tt>svn:mergeinfo</tt> properties?
>     56  faq.html:4089:<h3> Passwords which contain some special
characters do not seem to be working?
>     58  faq.html:4115:<h3>Why does an HTTP(S) URL-to-URL copy or
branch/tag operation
>     60  faq.html:4154:<h3>When performing Subversion operations

False positives due to long title text or extra newline between div
and heading tags.


>     79  security/CVE-2015-3184-advisory.txt:843:+ <h2>repos - Revision 1:
/A/D</h2>
>     81  security/CVE-2015-3184-advisory.txt:853:+ <h2>repos - Revision 1:
/A/D</h2>
>     83  security/CVE-2015-3184-advisory.txt:864:+ <h2>repos - Revision 1:
/A/D/H</h2>
>     85  security/CVE-2015-3184-advisory.txt:2924:+ <h2>repos - Revision
1: /A/D</h2>
>     87  security/CVE-2015-3184-advisory.txt:2934:+ <h2>repos - Revision
1: /A/D</h2>
>     89  security/CVE-2015-3184-advisory.txt:2945:+ <h2>repos - Revision
1: /A/D/H</h2>

Text files (patches, actually).

Cheers,
Nathan

Reply via email to