On Thu, Apr 08, 2021 at 08:01:43PM +0000, Daniel Shahaf wrote: > Good morning Stefan, > > stef...@apache.org wrote on Thu, Apr 08, 2021 at 14:35:52 -0000: > > Initial, single-theaded implementation of the svn_task__t API. > > I've committed some minor fixes in r1888533. Most of them are > straightforward but please double check that all the apostrophes are > where they should be. > > Here's also a review of task.c as it stands now.
Just adding another thing: It looks like task.c has undefined symbols during linking if APR is built without support for threads: ../../subversion/libsvn_subr/.libs/libsvn_subr-1.so.0.0: undefined reference to `apr_thread_exit' ../../subversion/libsvn_subr/.libs/libsvn_subr-1.so.0.0: undefined reference to `apr_thread_join' ../../subversion/libsvn_subr/.libs/libsvn_subr-1.so.0.0: undefined reference to `apr_thread_create' https://ci.apache.org/builders/svn-bb-openbsd/builds/673/steps/Build/logs/stdio There's probably just a missing check for the APR_HAS_THREADS macro. This build bot is running a non-threaded build in order to catch such issues. In reality this is likely an non-issue for most people. But as long as we intend to support the !APR_HAS_THREADS case our code should compile in both cases. I don't have time right now to fix this myself, sorry. Cheers, Stefan
