Daniel Sahlberg wrote on Tue, Feb 16, 2021 at 12:44:45 +0100: > Den mån 15 feb. 2021 kl 21:07 skrev Daniel Shahaf <d...@daniel.shahaf.name>: > > > dsahlb...@apache.org wrote on Sat, Feb 13, 2021 at 21:41:10 -0000: > > > +++ subversion/site/staging/docs/community-guide/releasing.part.html Sat > > Feb 13 21:41:10 2021 > > > @@ -1255,80 +1255,24 @@ href="https://reporter.apache.org/addrel > > > > > > </div> <!-- releasing-upload --> > > > > > > -<div class="h4" id="releasing-press"> > > > > Here, you moved some 70 lines and also made a change between the pre-move > > and > > post-move form. First, here's the delta for ease of review: > > > > Sorry, should have done it in two commits.
Sure, if doing so was possible in this case. I looked before sending and wasn't sure. > > [[[ > > -<p>NOTE: We announce the release before updating the website since the > > website > > -update links to the release announcement sent to the announce@ mailing > > list.</p> > > +<p>NOTE: We update the website before announce the release to make sure > > any > > +links in the release announcement are valid. After announcing the release, > > +links to the release announcement e-mail are added to the website.</p> > > ]]] > > > > On the first added line, "before announce the release" is ungrammatical. > > > > Fixed (I hope..), r1886586. Yeah, that's fine. > > Sounds like we should make write-news generate the HTML comment marker in > > advance, and only ask the RM to remove them. (The RM has a fair amount of > > work as it is; every little bit helps.) > > > > Very reasonable, patch below. I'm adding the comment unless there is an > announcement url in command line arguments. I'm not happy about the > [if-any][else] construct but I couldn't find a way to check "if not any", > from a quick glance at the documentation in gsteins gihub repo. No, that construct is fine; you'll find examples of it in build/generator/templates/. > +++ tools/dist/templates/rc-news.ezt (working copy) > @@ -8,8 +8,18 @@ > release is not intended for production use, but is provided as a milestone > to encourage wider testing and feedback from intrepid users and > maintainers. > Please see the > +[if-any announcement_url] > +[else] The newline between the «]» and the «[» would get copied to the output if the condition is true. Is that intentional? > > P.S. While reviewing this I noticed that > > https://subversion-staging.apache.org/favicon.ico is different to > > https://svn.apache.org/repos/asf/subversion/site/staging/favicon.ico: an > > Apache > > feather v. a Subversion logo. > > > > Hmm. That is very strange. I've pinged infra on Slack. IIRC, subversion-staging.apache.org has its own <VirtualHost/> definition, separate from the one used by all ${pmc}.apache.org sites, so it's not that surprising that some edge cases are different. Thanks for chasing this up! Re downthread, PMC Unix names can't contain dashes. (empire-db is a grandfathered exception.) Cheers, Daniel
